-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added adapter filter #377
Added adapter filter #377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we need to makes sure we have test cases covering all your bullet points
Added tests. |
After trying out your branch, we should discuss some user experience options:
For docs, we should make the examples use wildcards in single quotes: dsc resource list '*os*' As on non-Windows, the shell will try to glob the wildcard and pass found files to the command causing it to fail. |
My thoughts:
It is shorter to type
I agree with this; it is more intuitive than current behavior. |
Get-dscresource allows the user to specify a module or individual resource. The operation is faster when it is scoped. That might be worth considering as well. |
We would have a |
Updated code and PR description for both points. |
Co-authored-by: Steve Lee <slee@microsoft.com>
Co-authored-by: Steve Lee <slee@microsoft.com>
Co-authored-by: Steve Lee <slee@microsoft.com>
Co-authored-by: Steve Lee <slee@microsoft.com>
PR Summary
Fix #274
Fix #368
Examples:
dsc resource list
same asdsc resource list *
- show all native resources, adapters, but not adapter-based resources (fastest);dsc resource list *Microsoft*
- same as previous but also apply*Microsoft*
filter;dsc resource list * -a *
- show all adapter-based resources;dsc resource list * -a *PowerShell*
- show all resources of adapters that match*PowerShell*
filterdsc resource list *MSFT_PackageManagement* *PowerShell*
- same as previous but also apply*MSFT_PackageManagement*
filter to resource types;