Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making PowerShell adapter and class-based resources cross-platform #439

Merged
merged 5 commits into from
May 30, 2024

Conversation

anmenaga
Copy link
Collaborator

@anmenaga anmenaga commented May 24, 2024

PR Summary

This removes PowerShell adapter's dependency on PSDesiredStateConfiguration module, therefore making class-based PS resources cross-platform.

There is a number of minor follow-up TODOs in the code that will be filed as issues once this base code is reviewed/approved.

Performance impact: tests showed roughly 50% time improvement over classic Get-DscResource cmdlet; e.g.:

Measure-Command { Get-DscClassResourceDefinitions }
TotalSeconds      : 0.8507316

Measure-Command { Get-DscResource }
TotalSeconds      : 2.1735731

@anmenaga anmenaga requested a review from SteveL-MSFT May 24, 2024 19:18
@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue May 30, 2024
Merged via the queue into PowerShell:main with commit c84ee9b May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants