Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registry whatif #465

Merged
merged 12 commits into from
Jun 26, 2024
Merged

Add registry whatif #465

merged 12 commits into from
Jun 26, 2024

Conversation

tgauth
Copy link
Collaborator

@tgauth tgauth commented Jun 17, 2024 •
edited
Loading

PR Summary

image
  • example output for clobbering an existing value:
image
  • example output for an insufficient permissions error:
image

PR Context

  • start of whatIf for registry resource, to be continued once metadata can be passed back from resources

@tgauth tgauth marked this pull request as ready for review June 18, 2024 20:46
SteveL-MSFT
SteveL-MSFT requested changes Jun 20, 2024
View reviewed changes
registry/src/registry_helper.rs Outdated Show resolved Hide resolved
registry/src/main.rs Outdated Show resolved Hide resolved
registry/src/config.rs Outdated Show resolved Hide resolved
SteveL-MSFT
SteveL-MSFT requested changes Jun 21, 2024
View reviewed changes
registry/src/registry_helper.rs Outdated Show resolved Hide resolved
registry/src/registry_helper.rs Outdated Show resolved Hide resolved
@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Jun 26, 2024
Merged via the queue into PowerShell:main with commit b017179 Jun 26, 2024
4 checks passed
@tgauth tgauth deleted the add-registry-what-if branch August 27, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement whatif for Registry resource
2 participants
@tgauth @SteveL-MSFT