Add specific error if PS class resource doesn't implement export #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmenaga
approved these changes
Aug 5, 2024
| @@ -475,6 +475,10 @@ function Invoke-DscOperation { | |||
| 'Export' { | |||
| $t = $dscResourceInstance.GetType() | |||
| $method = $t.GetMethod('Export') | |||
| if ($null -eq $method) { | |||
There was a problem hiding this comment.
psDscAdapter\win_psDscAdapter.psm1 needs a similar change.
There was a problem hiding this comment.
WinPS Adapter doesn't support export
| { | ||
| } | ||
|
|
||
| [bool] Test() |
There was a problem hiding this comment.
for this NoExport class I would get rid of all not-used business-logic (if conditions) in Test and Get methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The current adapter needs a check when discovering the
exportmethod of a class and it's not found. In this case, it will return a specific error message isexportis attempted and not implemented:PR Context
Fix #503