Add error message for PowerShell adapter without input #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9443e1c.
|
@anmenaga Can you review this PR? It's a small one. |
anmenaga
suggested changes
Aug 8, 2024
| @@ -66,6 +66,11 @@ if ($jsonInput) { | |||
| if ($jsonInput -ne '@{}') { | |||
| $inputobj_pscustomobj = $jsonInput | ConvertFrom-Json | |||
| } | |||
| else | |||
| { | |||
| $jsonInput = $jsonInput | ConvertTo-Json | |||
There was a problem hiding this comment.
I'm a little confused about the problem this PR is trying to fix; Can you please give examples of expected behavior and actual behavior?
There was a problem hiding this comment.
Whenever a user tries to do a get operation on a resource without specifying any input, it should give a proper error message to the user. That's it actually. If it can be captured higher level, that would also do the trick.
|
A generic fix for this issue is in #525 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The PowerShell adapter requires a check whenever input is empty, it should return a proper error message. In this case, the default @{} was given as a parameter without converting it to JSON. Now it checks the JSON input and if empty, converts it still to an empty JSON string.