Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class-based PowerShell DSC Resources should not include hidden properties #556

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Class-based PowerShell DSC Resources should not include hidden properties #556

merged 6 commits into from
Sep 20, 2024

Conversation

anmenaga
Copy link
Collaborator

@anmenaga anmenaga commented Sep 19, 2024 •
edited
Loading

PR Summary

Fix #157

Adding filtering of the returned properties to only include properties with the DscProperty attribute, so that the schema surface for the resources matches with Get-DscResource and the contract that the class definition implements.

@anmenaga anmenaga marked this pull request as draft September 19, 2024 21:00
@anmenaga anmenaga marked this pull request as ready for review September 19, 2024 22:09
@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Sep 20, 2024
Merged via the queue into PowerShell:main with commit 5b46548 Sep 20, 2024
5 checks passed
@Gijsreyn Gijsreyn mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@tgauth tgauth Awaiting requested review from tgauth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class-based PowerShell DSC Resources include hidden properties in dsc config results
2 participants
@anmenaga @SteveL-MSFT