Enable Include resource to take configuration and parameters as string content
#626
+238
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The
Includeresource currently only takes the configuration to include and parameters as external files. This change enables a choice of either a file pathconfigurationFile,parametersFileor the content as a stringconfigurationContent,parametersContent(can be mixed). This is useful where another resource might generate a configuration that is used later within a larger configuration without needing to save it to a file first.@michaeltlombardi for docs, it's important that the nested JSON/YAML is a text string and NOT a nested object this is why the tests have embedded YAML as a multi-line string and the JSON in quotes.
There is future work to allow a nested object for configuration and parameters that can be added to the enum but not part of this PR.
Seems like there is a new clippy rule for unnecessary
mapuse so fixed that as well although unrelated to my changes.