Skip to content

".role" in a comment does not highlight correctly #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Blackbaud-ShaydeNofziger opened this issue Jun 15, 2018 · 1 comment
Closed

".role" in a comment does not highlight correctly #119

Blackbaud-ShaydeNofziger opened this issue Jun 15, 2018 · 1 comment
Assignees
Labels

Comments

@Blackbaud-ShaydeNofziger
Copy link

Blackbaud-ShaydeNofziger commented Jun 15, 2018

Environment

  • Editor and Version (VS Code, Atom, Sublime): VSCode, 1.25.0-insiders (Commit: 7dc9539a421c9c33e57e2ce0b718f183bb44c756)
  • Your primary theme: DefaultDark (issue occurs in all themes)

Issue Description

If a comment string contains .Role or .role, the word "role" is colored incorrectly.

Screenshots

image

Expected Behavior

.role/.Role should remain green/the color of the comments.

Code Samples

# This role works
# This .Role doesn't work
# This .role doesn't work
# $MachineParts.RoleCode
@omniomi omniomi self-assigned this Jun 15, 2018
@omniomi omniomi added the bug label Jun 15, 2018
@omniomi
Copy link
Contributor

omniomi commented Jun 15, 2018

Looks like we missed a negative lookbehind for words in front of comment.documentation.embedded.powershell within the commentEmbeddedDocs repository section. The match should insure nothing but white space or the # symbol between the beginning of the line and the ..

Good catch, will fix; Thanks.

omniomi added a commit to omniomi/EditorSyntax that referenced this issue Jun 18, 2018
@omniomi omniomi mentioned this issue Jun 18, 2018
@vors vors closed this as completed in #120 Jun 19, 2018
vors pushed a commit that referenced this issue Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants