-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double-quoted strings treat @tokens as interpolations #149
Comments
This has been mentioned in #137. |
remove #variable from #doubleQuotedString, remove @ from #variableNoProperty
I was looking at the possible test case, but I don't think it is sufficient, but I may not entirely understand how the test works. In my mind, the entire string will scope as spec'd, regardless of whether the |
Looks like this is needed? # @splat references only work in argument mode, should not highlight in strings.
"This is a @double quoted string."
# ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ string.quoted.double.powershell
# ^ not:variable.other.readwrite.powershell |
That seems right, @msftrncs. I would recommend running the test before and after your change to see if it fixes the test. |
Environment
Issue Description
Double-quoted strings color
@tokens
the same as$tokens
Screenshots
Expected Behavior
Only
$tokens
or$(expressions)
are string-interpolated in a double-quoted string. The@word
is just going to be treated as part of the string.Code Samples
This may be an appropriate spec test case:
The text was updated successfully, but these errors were encountered: