Skip to content

CompressArchiveCommand: fix issues with progress formatting #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CompressArchiveCommand: fix issues with progress formatting #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/CompressArchiveCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ protected override void EndProcessing()
{
// Update progress
var percentComplete = numberOfAddedItems / (float)numberOfAdditions * 100f;
progressRecord.StatusDescription = string.Format(Messages.ProgressDisplay, "{percentComplete:0.0}");
progressRecord.StatusDescription = string.Format(Messages.ProgressDisplay, $"{percentComplete:0.0}");
WriteProgress(progressRecord);

if (ShouldProcess(target: entry.FileSystemInfo.FullName, action: Messages.Add))
Expand All @@ -219,7 +219,7 @@ protected override void EndProcessing()

// Once all items in the archive are processed, show progress as 100%
// This code is here and not in the loop because we want it to run even if there are no items to add to the archive
progressRecord.StatusDescription = string.Format(Messages.ProgressDisplay, "100.0");
progressRecord.StatusDescription = string.Format(Messages.ProgressDisplay, $"{100.0:0.0}");
WriteProgress(progressRecord);
}
finally
Expand Down