Fix msi package tests

[mhendric]

Pull Request (PR) description

Fixes issue where MsiPackage Integration tests fail if strong crypto is not enabled for .NET 4.

This Pull Request (PR) fixes the following issues

• Fixes MSFT_MsiPackage.Integration.Tests.ps1: Tests fail with: RuntimeException: The variable '$responseStream' cannot be retrieved because it has not been set #142

Task list

• Added an entry under the Unreleased section of the change log in the README.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[codecov-io]

Codecov Report

Merging #143 into dev will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #143   +/-   ##
===================================
  Coverage    83%    83%           
===================================
  Files        19     19           
  Lines      2760   2760           
  Branches      4      4           
===================================
  Hits       2305   2305           
  Misses      451    451           
  Partials      4      4

[mhendric]

@PlagueHO , would you mind giving this one a review? Thanks.

[PlagueHO]

Sorry about the delay @mhendric ! Back on board now (been tied up with other projects the last few weeks). Reviewing now!

[PlagueHO]

@mhendric - needs conflicts resolved BTW.

[PlagueHO]

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @mhendric)

---

README.md, line 581 at r1 (raw file):

* Fixes issue where MsiPackage Integration tests fail to make an HTTPS
  connection if Strong Crypto for .NET is not enabled.

Minor nitpick: for consistency could use: ...NET is not enabled - Fixes Issue #142.

Although it doesn't look like there is huge consistency anyway 😁 so up to you.

---

Tests/Integration/MSFT_MsiPackage.EndToEnd.Tests.ps1, line 23 at r1 (raw file):

# Make sure strong crypto is enabled in .NET for HTTPS tests
Enable-StrongCryptoForDotNetFour

Should we also preserve state and restore it afterwards? If tests are being run on a developer machine it might cause difficult to diagnose issues.

---

Tests/Integration/MSFT_MsiPackage.Integration.Tests.ps1, line 21 at r1 (raw file):

# Make sure strong crypto is enabled in .NET for HTTPS tests
Enable-StrongCryptoForDotNetFour

Should we also preserve state and restore it afterwards? If tests are being run on a developer machine it might cause difficult to diagnose issues.

---

Tests/TestHelpers/CommonTestHelper.psm1, line 800 at r1 (raw file):

{
    [CmdletBinding()]
    param()

Can you add space after param?

---

Tests/TestHelpers/CommonTestHelper.psm1, line 826 at r1 (raw file):

        else
        {
            Write-Warning -Message "Failed to find registry key at path: $regPath. Skipping setting SchUseStrongCrypto to 1."

Maybe mention that this may cause Integration tests to fail in the message here?

[PlagueHO]

Let me know when you're ready for me to finish the review @mhendric

[mhendric]

Will do @PlagueHO . Sorry for the delay. I haven't had a chance to troubleshoot the most recent test failures yet. I'll ping you once I get a clean build though. Thanks.

[mhendric]

Hey @PlagueHO , finally got this fixed. Would you mind reviewing again when you have a chance? Thanks.

[mhendric]

Hi @PlagueHO , checking to see if you can complete the review on this one? This PR is holding up a couple other PR's. Thanks.

[PlagueHO]

Oh yes. Sorry about that @mhendric - I'll aim to complete tonight.

[PlagueHO]

Reviewed 1 of 4 files at r2, 2 of 2 files at r3, 1 of 1 files at r4.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mhendric)