-
Notifications
You must be signed in to change notification settings - Fork 53
MSFT_GroupResource: Fix for the issue #82 #198
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look sound and only apply on error.
Awesome, thank you. Now somebody with write permissions to the repository should merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for contributing this!
If we make the change in this repo, then we should also submit the same change to the xPSDesiredStateConfiguration repository as well: https://github.com/dsccommunity/xPSDesiredStateConfiguration - Ideally we should try and keep these in sync.
Regarding the xPSDesiredStateConfiguration repo. Once all the changes are finalized and ready to be merged, I will fork the xPSDesiredStateConfiguration and create a PR with proposed changes to keep them in sync. Don't want to do it prematurely to avoid having to make changes in 2 places at once. |
Pull Request (PR) description
This PR implements proposed workaround for the issue #82. See the issue discussion for the details.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.