Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

MSFT_GroupResource: Fix for the issue #82 #198

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

SDedik
Copy link

@SDedik SDedik commented Apr 29, 2021

Pull Request (PR) description

This PR implements proposed workaround for the issue #82. See the issue discussion for the details.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@ghost
Copy link

ghost commented Apr 29, 2021

CLA assistant check
All CLA requirements met.

Copy link

@Sudman1 Sudman1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look sound and only apply on error.

@SDedik
Copy link
Author

SDedik commented May 7, 2021

Awesome, thank you. Now somebody with write permissions to the repository should merge it.

@PlagueHO PlagueHO added needs review The pull request needs a code review. waiting for CLA pass The contributor has not yet signed the CLA so that pull request check is not successful. and removed waiting for CLA pass The contributor has not yet signed the CLA so that pull request check is not successful. labels May 7, 2021
Copy link
Contributor

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for contributing this!

If we make the change in this repo, then we should also submit the same change to the xPSDesiredStateConfiguration repository as well: https://github.com/dsccommunity/xPSDesiredStateConfiguration - Ideally we should try and keep these in sync.

CHANGELOG.md Show resolved Hide resolved
DscResources/MSFT_GroupResource/MSFT_GroupResource.psm1 Outdated Show resolved Hide resolved
@SDedik
Copy link
Author

SDedik commented May 7, 2021

Regarding the xPSDesiredStateConfiguration repo. Once all the changes are finalized and ready to be merged, I will fork the xPSDesiredStateConfiguration and create a PR with proposed changes to keep them in sync. Don't want to do it prematurely to avoid having to make changes in 2 places at once.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group: Unable to add Different forest User to Local Group
3 participants