Skip to content

Many custom keybindings broken with latest build (1.0.200) from AppVeyor #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gwojan opened this issue Nov 14, 2017 · 3 comments · Fixed by #657
Closed

Many custom keybindings broken with latest build (1.0.200) from AppVeyor #580

gwojan opened this issue Nov 14, 2017 · 3 comments · Fixed by #657
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@gwojan
Copy link

gwojan commented Nov 14, 2017

I just dropped the AppVeyor build 1.0.200 onto my machine and noticed a whole bunch of my custom key bindings no longer work.

Set-PSReadlineKeyHandler -Chord 'Ctrl+['                    -Function ViCommandMode
Set-PSReadlineKeyHandler -ViMode Command -Chord 'Ctrl+Shift+[' -Function DeleteLine
Set-PSReadlineKeyHandler -Chord 'Ctrl+Shift+['              -Function DeleteLine
Set-PSReadlineKeyHandler -Chord 'Alt+n'                     -Function HistorySearchBackward
Set-PSReadlineKeyHandler -ViMode Command -Chord 'Alt+n'     -Function HistorySearchBackward

This is just a few that I've noticed so far -- the most obvious ones that I use all the time. 😉

I'll update as I find more.

Environment data

PS version: 5.1.15063.674
PSReadline version: 2.0
os: 10.0.15063.0 (WinBuild.160101.0800)
PS file version: 10.0.15063.0 (WinBuild.160101.0800)-->

Steps to reproduce or exception report

@lzybkr
Copy link
Contributor

lzybkr commented Nov 14, 2017

I made a change to basically ignore Shift most of the time so that key bindings aren't tied to specific keyboard layouts, and also so that the code is more portable because Shift is not always reported on Linux.

Assuming an English keyboard, Ctrl+{ should work instead of Ctrl+Shift+[.

As for Alt+n - it works for me.

And thanks so much for testing pre-prerelease. I'm still waiting for the PSGallery team to accept prerelease modules, but it's great to get the feedback even earlier.

@gwojan
Copy link
Author

gwojan commented Nov 14, 2017

@lzybkr Interesting... The Alt+n issue was due to the ordering of the commands. I had:

Set-PSReadlineKeyHandler -Chord 'Alt+n'                     -Function HistorySearchBackward
Set-PSReadlineKeyHandler -Chord 'Alt+Shift+n'                     -Function HistorySearchForward

The shifted command was undoing the first command. Changing to Alt+N has resolved that issue.

However, I can not get Ctrl+[ and Ctrl+{ to work.

You're most welcome regarding the testing. I can't live without Vi mode! 😄 You and @srdubya have done an amazing job!

@lzybkr
Copy link
Contributor

lzybkr commented Nov 14, 2017

Thanks - I've confirmed Ctrl+[ and Ctrl+{ are not working.

@lzybkr lzybkr added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Nov 14, 2017
@lzybkr lzybkr added this to the 2.0.0-beta2 milestone Mar 20, 2018
lzybkr pushed a commit that referenced this issue Mar 25, 2018
powercode pushed a commit to powercode/PSReadLine that referenced this issue Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants