De-duplicate prediction results with the history results #3543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @StevenBucher98: this is for the de-duplication work item. It could be great if we can verify the new user experience with Az predictor (if we can reproduce the issue in Az predictor). |
StevenBucher98
approved these changes
Jan 20, 2023
andyleejordan
approved these changes
Jan 23, 2023
Comment on lines
+479
to
+488
| // NOTE: when any duplicate results were skipped, the 'count' passed in here won't be accurate as it still includes | ||
| // those skipped ones. This is due to the limitation of the 'OnSuggestionDisplayed' interface method, which didn't | ||
| // assume any prediction results from a predictor could be filtered out at the initial design time. We will have to | ||
| // change the predictor interface to pass in accurate information, such as: | ||
| // void OnSuggestionDisplayed(Guid predictorId, uint session, int countOrIndex, int[] skippedIndices) | ||
| // | ||
| // However, an interface change has huge impacts. At least, a newer version of PSReadLine will stop working on the | ||
| // existing PowerShell 7+ versions. For this particular issue, the chance that it could happen is low and the impact | ||
| // of the inaccurate feedback is also low, so we should delay this interface change until another highly-demanded | ||
| // change to the interface is required in future (e.g. changes related to supporting OpenAI models). |
There was a problem hiding this comment.
Thanks for the detailed note 👍
|
Thank you both for the reivew! |
1 task
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
De-duplicate prediction results with the history results.
A prediction result could be the same as the one found in history. This happens sometimes to the Az predictor.
When used in list view, it's confusing for the user to see 2 same results in the list, both from history and a predictor. So, we de-duplicate the prediction results against the history results.
For now, we only remove the prediction results that are exactly the same (case-sensitive or case-insensitive decided by the user with the 'HistorySearchCaseSensitive' setting, which is
falseby default) as one of the history results.PR Checklist
Microsoft Reviewers: Open in CodeFlow