Skip to content

Add a private field to indicate if PSReadLine is initialized and ready #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

Add a private field to indicate if PSReadLine is initialized and ready #4706

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82d2128
Add a private field to indicate if PSReadLine is initialized and ready
daxian-dbw Apr 10, 2025
39e5b67
Add comment
daxian-dbw Apr 16, 2025
450b38e
update comment
daxian-dbw Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions PSReadLine/ReadLine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ public partial class PSConsoleReadLine : IPSConsoleReadLineMockableMethods
#pragma warning restore CS0649

private bool _delayedOneTimeInitCompleted;
// This is used by AIShell to check if PSReadLine is initialized and ready to render.
private bool _readLineReady;

private IPSConsoleReadLineMockableMethods _mockableMethods;
private IConsole _console;
Expand Down Expand Up @@ -400,6 +402,7 @@ public static string ReadLine(
_singleton.Initialize(runspace, engineIntrinsics);
}

_singleton._readLineReady = true;
_singleton._cancelReadCancellationToken = cancellationToken;
return _singleton.InputLoop();
}
Expand Down Expand Up @@ -472,6 +475,8 @@ public static string ReadLine(
}
finally
{
_singleton._readLineReady = false;

try
{
// If we are closing, restoring the old console settings isn't needed,
Expand Down