Skip to content

Fix init for non-US keyboards #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Fix init for non-US keyboards #768

merged 1 commit into from
Sep 28, 2018

Conversation

lzybkr
Copy link
Contributor

@lzybkr lzybkr commented Sep 27, 2018

Fix #614

@jeanga
Copy link

jeanga commented Oct 4, 2018

With the release of RS5, non US users for PSReadLine badly need an official release with this fix.
Thanks!

@lzybkr
Copy link
Contributor Author

lzybkr commented Oct 4, 2018

@jeanga - Hopefully @SteveL-MSFT can make that happen.

@SteveL-MSFT
Copy link
Member

@jeanga, @lzybkr I think after the UTF8 OutputEncoding PR gets merged, it makes sense to have another beta release

@Thdub
Copy link

Thdub commented Oct 9, 2018

Also hope to see beta4 soon!

@lzybkr
Copy link
Contributor Author

lzybkr commented Oct 9, 2018

@Thdub - I'd like to get a few more fixes in before Beta4 - but until then, you can grab a build out of AppVeyor.

@gcollic
Copy link

gcollic commented Dec 3, 2018

Is there any official release coming soon with this fix ? Windows Update broke my shell, not really happy about it :-(

@lzybkr
Copy link
Contributor Author

lzybkr commented Dec 3, 2018

@gcollic - I'm aiming to get another release out before the end of the year. This is strictly a spare (personal) time project for me so it does take a bit longer.

@gcollic
Copy link

gcollic commented Dec 3, 2018

Oh sorry, I didn't realized it was a personal project and not exactly a Windows component. Thanks for your work, if I'm unhappy it broke it's because I love what this module enables !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants