Cmdlets have SupportsShouldProcess but don't actually implement it

[ThomasNieto]

Cmdlets have SupportsShouldProcess but don't actually implement it for -WhatIf and -Confirm parameters. This gives users a false sense of security.

• Install-PSResource
• Publish-PSResource
• Save-PSResource
• Update-PSResource
• Uninstall-PSResource
• Register-PSResourceRepository
• Unregister-PSResourceRepository
• Set-PSResourceRepository

These don't need SupportsShouldProcess since they are non-state changing cmdlets.

• Get-PSResourceRepository
• Find-PSResource
• Get-PSResource

[issue-label-bot]

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.81. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[SydneyhSmith]

Thanks @ThomasNieto for calling this out, we do plan to implement

[alerickson]

This is complete for all of the mentioned cmdlets except for Save-PSResource. We'll add this in shortly.

[alerickson]

Resolved with PR #447