Skip to content

Cmdlets have SupportsShouldProcess but don't actually implement it #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ThomasNieto opened this issue Oct 4, 2020 · 4 comments
Closed

Cmdlets have SupportsShouldProcess but don't actually implement it #279

ThomasNieto opened this issue Oct 4, 2020 · 4 comments
Assignees
@anamnavi
Labels
Issue-Bug Something isn't working
Milestone
1.0-Approved

Comments

@ThomasNieto
Copy link
Contributor

ThomasNieto commented Oct 4, 2020 •
edited
Loading

Cmdlets have SupportsShouldProcess but don't actually implement it for -WhatIf and -Confirm parameters. This gives users a false sense of security.

  • Install-PSResource
  • Publish-PSResource
  • Save-PSResource
  • Update-PSResource
  • Uninstall-PSResource
  • Register-PSResourceRepository
  • Unregister-PSResourceRepository
  • Set-PSResourceRepository

These don't need SupportsShouldProcess since they are non-state changing cmdlets.

  • Get-PSResourceRepository
  • Find-PSResource
  • Get-PSResource
@issue-label-bot issue-label-bot bot added the Issue-Bug Something isn't working label Oct 4, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.81. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@SydneyhSmith SydneyhSmith added this to the 3.0-Resolved milestone Oct 8, 2020
@SydneyhSmith
Copy link
Collaborator

Thanks @ThomasNieto for calling this out, we do plan to implement

This was referenced Apr 14, 2021
Merged
Merged
@anamnavi anamnavi self-assigned this Apr 14, 2021
This was referenced Jul 21, 2021
Merged
Merged
@alerickson
Copy link
Member

This is complete for all of the mentioned cmdlets except for Save-PSResource. We'll add this in shortly.

@anamnavi anamnavi mentioned this issue Aug 5, 2021
Merged
14 tasks
@alerickson
Copy link
Member

Resolved with PR #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anamnavi anamnavi

Labels
Issue-Bug Something isn't working
Projects
None yet
Milestone
1.0-Approved
Development

No branches or pull requests
4 participants
@alerickson @anamnavi @ThomasNieto @SydneyhSmith