Skip to content

Performance improvements for find/install #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SydneyhSmith opened this issue May 24, 2022 · 3 comments
Closed

Performance improvements for find/install #653

SydneyhSmith opened this issue May 24, 2022 · 3 comments

Comments

@SydneyhSmith
Copy link
Collaborator

SydneyhSmith commented May 24, 2022

Summary of the new feature / enhancement

Based on the investigation in issue PowerShell/PowerShellGet#641 we have come to the following ideas:

  • Fix IEnumerable issues PowerShell/PowerShellGet#654
  • Refactor Find to use IRepositorySearch (with current nuget APIs) PowerShell/PowerShellGet#655
  • (optionally) Look at IDownloadPackage refactor
  • Use Find local cache PowerShell/PowerShellGet#613
  • Look at new implementations using HTTPClient

Proposed technical implementation details (optional)

No response

@JustinGrote
Copy link
Contributor

@SydneyhSmith PowerShell/PowerShellGallery#241 might be related at least for powershell gallery "Az*" searches.

@JustinGrote
Copy link
Contributor

Even though I implemented it in native powershell, you may want to look at how I used a native httpclient to speed up installs of the Az module from 2 minutes to 5 seconds :).

The same logic can easily apply to C# and can be much faster if the awaitable tasks are chained together (which I can't really feasibly do in PowerShell)

https://github.com/JustinGrote/ModuleFast/blob/main/ModuleFast.ps1

@alerickson
Copy link
Member

closing this in favor of #655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants