Skip to content

[Performance improvements for find/install] Refactor Find to use IRepositorySearch #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SydneyhSmith opened this issue May 24, 2022 · 1 comment · Fixed by #772
Closed

Comments

@SydneyhSmith
Copy link
Collaborator

SydneyhSmith commented May 24, 2022

Summary of the new feature / enhancement

  • Find is inconsistently used, and server APIs sometimes called directly for same purpose.
    This makes it impossible to add a simple client side cache to cover cases:
    Find-PSResource -Name Az* -Repository PSGallery -SkipPublishersCheck:$false
  • Need to have clean serach interface that covers all search scenarios:
  • IRepositorySearch
  • Find(repositoryName, string packageName) -> Find latest version single pkg (no wild card)
  • Find(repositoryName, string[] packageName) -> Find latest version of multiple pkg names (wildcard supported)
  • Find(repositoryName, string packageName, version) -> Find single pkg with version (no wild card)
  • Find(repositoryName, string[] packageName, version) -> Find multiple pkg names with version (wildcard supported)
  • FindAll() ->
  • IRepositoryPackage
  • GetPackage(repositoryName, string packageName)
  • GetPackage(repositoryName, string[] packageName)
  • GetPackage(repositoryName, string[] package, version)
  • Dependency search does not use Find method, but calls nuget search APIs directly.

Proposed technical implementation details (optional)

No response

@alerickson
Copy link
Member

Closing this issue in favor of #746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants