Publish-PSResource should create nupkg packages with lowercased name #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerickson
approved these changes
Jul 20, 2023
| File.Copy(System.IO.Path.Combine(outputNupkgDir, nupkgName), System.IO.Path.Combine(DestinationPath, nupkgName)); | ||
| string srcPath = System.IO.Path.Combine(outputNupkgDir, nupkgName); | ||
| // The file that gets created upon Copy should have lowercased package name. | ||
| string destPath = System.IO.Path.Combine(DestinationPath, nupkgName.ToLower()); |
There was a problem hiding this comment.
Do we care about the destination path not matching case?
There was a problem hiding this comment.
I don't see why we would care...the file path at the destination should always have lower case, as that's what we put there and expect to see after publish. The srcPath has to match the case as it's the file name with the casing the (Windows or Unix) system sees and has to copy
adityapatwardhan
approved these changes
Jul 20, 2023
Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
14 tasks
SydneyhSmith
added
PR-Bug
SydneyhSmith
removed
PR-Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.