Fixes bug with nuspec dependency version range calculation for RequiredModules

[afroz429]

PR Summary

Fix for #1777. The PR generates correct nuspec dependency version range for modules specified in RequiredModules section of the module manifest file.

Per the nuget version reference doc

• When RequiredVersion is specified, the version range is set as [RequiredVersion] which is an exact match

• When MaximumVersion is specified, the version range is set as (, MaximumVersion] which is <=MaximumVersion

• When ModuleVersion is specified, the version range is set as ModuleVersion which is >=ModuleVersion. This notation is used since publish-module uses the same notation

• When both ModuleVersion and MaximumVersion are specified, the version range is set to [ModuleVersion, MaximumVersion] which is exact range, inclusive

• Added Pester tests

PR Context

Fix for #1777

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Documentation needed
    • Issue filed:
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

[afroz429]

@microsoft-github-policy-service agree

[anamnavi]

Thanks for creating this thorough PR @afroz429 I pushed a few commits to fix a separate test that wasn't cleaning up files written to unzippedPath, which meant when your test extracted files to that path it was throwing an error about needing to overwrite them. I also wrapped the code that checks which type of version the dependency version hashtable contains in an if block, for the case where the dependency name was provided without any version information.

[afroz429]

@anamnavi Thanks for cleaning up the PR and merging it. What time frame will this change release?

[adityapatwardhan]

@afroz429 we are planning a release this week. Thanks for the contribution!

[anamnavi]

@afroz429 the release with this change went out today, it's present in the latest stable version 1.1.1 of PSResourceGet thank you for the contribution!