Fix resourceinfo #367
Merged
Fix resourceinfo #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerickson
approved these changes
May 4, 2021
anamnavi
reviewed
May 4, 2021
| public string Repository { get; set; } | ||
| public string RepositorySourceLocation { get; set; } | ||
| public string[] Tags { get; set; } | ||
| public string Type { get; set; } |
There was a problem hiding this comment.
why is the type string and not ResourceType?
anamnavi
pushed a commit
that referenced
this pull request
Sep 7, 2022
* Move the PSResourceInfo class to its own source file, and rename test * Add missing copyright to new source file * Fix Codeacy warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR changes the name for PSResourceInfo class and also moves it from Utils to its own source file.
PR Context
After discussion, it was decided that the PSResourceInfo class should follow other conventions and reside in its own source file. Associated test file is also renamed.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.