Skip to content

WIP: Fix pipeline support for Version property for *-PSResource cmdlets #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

anamnavi
Copy link
Member

@anamnavi anamnavi commented Oct 10, 2021

PR Summary

Add pipeline support for the -Version parameter with ValueFromPipelineByPropertyName = true. Previously, the -Version parameter was being parsed and set to a default in BeginProcessing() however to support this for pipeline input, it should be parsed in ProcessRecord(). Uninstall-PSResource doesn't need an InputObject parameter set, as it can just read properties by name for the piped in PSResourceInfo object.

PR Context

To fully support pipeline input, resolves issues #482

PR Checklist

@@ -156,6 +144,23 @@ protected override void ProcessRecord()
return;
}

// TODO: what should versionRange be by default;
Copy link
Member Author

@anamnavi anamnavi Oct 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ask @alerickson if default -Version value should be VersionRange.All for Save-PSResource and remove TODO

@anamnavi anamnavi changed the title Fix pipeline support for Fix pipeline support for Version property for *-PSResource cmdlets Oct 10, 2021
@anamnavi anamnavi requested a review from alerickson October 11, 2021 17:16
@anamnavi anamnavi changed the title Fix pipeline support for Version property for *-PSResource cmdlets WIP: Fix pipeline support for Version property for *-PSResource cmdlets Oct 11, 2021
@anamnavi
Copy link
Member Author

opened #510 and #511 instead.

@anamnavi anamnavi closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant