-
Notifications
You must be signed in to change notification settings - Fork 98
WIP: Fix pipeline support for Version property for *-PSResource cmdlets #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to support pipeline input
anamnavi
commented
Oct 10, 2021
src/code/SavePSResource.cs
Outdated
@@ -156,6 +144,23 @@ protected override void ProcessRecord() | |||
return; | |||
} | |||
|
|||
// TODO: what should versionRange be by default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ask @alerickson if default -Version
value should be VersionRange.All for Save-PSResource and remove TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add pipeline support for the
-Version
parameter withValueFromPipelineByPropertyName = true
. Previously, the-Version
parameter was being parsed and set to a default inBeginProcessing()
however to support this for pipeline input, it should be parsed in ProcessRecord(). Uninstall-PSResource doesn't need an InputObject parameter set, as it can just read properties by name for the piped in PSResourceInfo object.PR Context
To fully support pipeline input, resolves issues #482
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.