Add uninstall pipeline support for ValueFromPipelineByPropertyName #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerickson
changed the title
alerickson
changed the title
alyssa1303
reviewed
Aug 26, 2022
| [ValidateNotNullOrEmpty] | ||
| public string[] Name { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Specifies the version or version range of the package to be uninstalled. | ||
| /// </summary> | ||
| [Parameter(ParameterSetName = NameParameterSet)] | ||
| [Parameter(ValueFromPipelineByPropertyName = true, ParameterSetName = NameParameterSet)] |
There was a problem hiding this comment.
I tested Uninstall-PSResource on the current master branch and it actually works with pipeline input without your change, so I'm curious if the issue for the user might not come from not setting ValueFromPipelineByPropertyName to true.
alyssa1303
reviewed
Aug 26, 2022
|
|
||
| Get-PSResource -Name $testModuleName -Version "3.0.0" | Uninstall-PSResource | ||
| $res = Get-PSResource -Name $testModuleName -Version "3.0.0" | ||
| $res | Should -BeNullOrEmpty |
There was a problem hiding this comment.
I think it's better if you also test that versions 1.0.0 and 5.0.0 exist to ensure that Uninstall-PSResource only uninstall 1 version.
|
I opened this PR almost 2 months ago and it looks like this is no longer an issue. I'm searching for the PR where this issue was fixed, but I'm going to close this PR since it's no longer needed 😃 |
|
Originally resolved in: https://github.com/PowerShell/PowerShellGet/pull/593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add pipeline support in
Uninstall-PSResourceforValueFromPipelineByPropertyNamefor-Nameand-Versionso that only specified versions are uninstalled. Currently all versions get uninstalled since the version property isn't passed through the pipeline toUninstall-PSResource.PR Context
Resolves #626
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.