WIP: Populate companyname and other properties for PSResourceInfo #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and change their setters access levels
…y source location
anamnavi
changed the title
PaulHigin
suggested changes
Jul 20, 2022
| @@ -540,6 +540,10 @@ private IEnumerable<PSResourceInfo> FilterByInstalledPkgs(IEnumerable<PSResource | |||
| } | |||
|
|
|||
| moduleManifestVersion = parsedMetadataHashtable["ModuleVersion"] as string; | |||
| pkg.CompanyName = parsedMetadataHashtable["CompanyName"] as string; | |||
There was a problem hiding this comment.
Do we know that parsedMetadataHashtable will always have these entries?
|
@anamnavi, @alerickson please look at authenticode check test failures. |
anamnavi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing a package, save companyname, copyright and other metadata information to metadata xml file. Also change setters access levels for these properties of the PSResourceInfo class. Get-PSResource will now return consistent information for packages installed with Install-PSResource cmdlet after this fix.
When finding a package, companyname and other related information is not easily accessibly via the json metadata (IPackageSearchMetadata object returned via NuGet GetSearchAsync() and GetMetadataAsync() search APIs and currently is more operational cost than is worth to get this field. Here is a link listing the package information accessible via the package nuspec (note company name is not listed):
https://docs.microsoft.com/en-us/nuget/reference/nuspec
PR Summary
PR Context
Resolves #267
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.