Add -TemporaryPath parameter to Install-PSResource, Save-PSResource, and Update-PSResource

[alyssa1303]

PR Summary

This PR adds a parameter called -TemporaryPath for Install-PSResource, Save-PSResource, and Update-PSResource cmdlets, which allows users to set the directory for temporary installation.

PR Context

Resolves #650

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Documentation needed
    • Issue filed:
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

[alerickson]

Everything looks good-- just have 1 comment on providing user messaging. @anamnavi and @PaulHigin may have some opinions on that as well.

[anamnavi]

Not sure about whether we warn/throw/write error if the temp path directory does not exist, but aside from that looks great to me.

[PaulHigin]

I also noticed that the InstallHelper class is derived from PSCmdlet, and this is incorrect because it is not being processed as a PowerShell cmdlet. I think this was done so that the PSCmdlet ThrowTerminatingError() and WriteError() methods could be called. But this is incorrect (and I am not sure what the behavior is). InstallHelper should throw a normal C# exceptions and the top level cmdlets should catch and rethrow. Also InstallHelper should return a string[] for any errors to be reported by the top level cmdlet.

@alyssa1303 Can you make these changes, or create a new Issue to make these changes later (since this is not really in scope of this PR)?

[anamnavi]

I also noticed that the InstallHelper class is derived from PSCmdlet, and this is incorrect because it is not being processed as a PowerShell cmdlet. I think this was done so that the PSCmdlet ThrowTerminatingError() and WriteError() methods could be called. But this is incorrect (and I am not sure what the behavior is). InstallHelper should throw a normal C# exceptions and the top level cmdlets should catch and rethrow. Also InstallHelper should return a string[] for any errors to be reported by the top level cmdlet.

@alyssa1303 Can you make these changes, or create a new Issue to make these changes later (since this is not really in scope of this PR)?

I think creating an issue for that (and a separate PR) would be better.

[alyssa1303]

I created an issue #767

[anamnavi]

LGTM

[PaulHigin]

LGTM