Skip to content

Remove unneeded inheritance in InstallHelper.cs #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 23, 2022
Merged

Remove unneeded inheritance in InstallHelper.cs #773

merged 5 commits into from
Aug 23, 2022

Conversation

alyssa1303
Copy link
Contributor

@alyssa1303 alyssa1303 commented Aug 22, 2022

PR Summary

This PR removes inheritance of the class InstallHelper from PSCmdlet. This PR also fixes tests in InstallPSResource, SavePSResource, and UpdatePSResource to make sure the errors thrown are matched.

PR Context

Resolves #767

PR Checklist

@alyssa1303 alyssa1303 marked this pull request as ready for review August 22, 2022 15:21
@alyssa1303 alyssa1303 requested a review from PaulHigin August 22, 2022 17:55
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alyssa1303 alyssa1303 merged commit dee8d95 into PowerShell:master Aug 23, 2022
anamnavi pushed a commit that referenced this pull request Sep 7, 2022
Remove unneeded inheritance in InstallHelper.cs
@alyssa1303 alyssa1303 added PR-Bug This pull request resolves an issue bug Release This pull request is part the next release labels Sep 22, 2022
@alyssa1303 alyssa1303 removed the Release This pull request is part the next release label Nov 2, 2022
@SydneyhSmith SydneyhSmith removed the PR-Bug This pull request resolves an issue bug label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InstallHelper should not inherit from PSCmdlet
4 participants