Make -Path a required parameter for Save-PSResource cmdlet #780
Conversation
anamnavi
changed the title
| else { | ||
| resolvedPath = SessionState.Path.GetResolvedPSPathFromPSPath(value).First().Path; | ||
| } | ||
| if (WildcardPattern.ContainsWildcardCharacters(value)) |
There was a problem hiding this comment.
I think instead of checking for wildcards here we should try to resolve the path and if that throws, catch and display the error.
There was a problem hiding this comment.
That way if there's any issues at all with the path we can properly handle and emit the error.
There was a problem hiding this comment.
The problem with wildcards in the path is that they can return multiple matches, and then which path do we use? Whatever we choose will not be apparent to the user, unless we write out a message.
I feel we should not support wildcards in this case, and require the user to provide a single path that resolves to a real location. If not then that is a terminating error. We don't need to test the path and return an error, because GetResolvedPSPathFromPSPath already does this and throws an exception with a readable error:
"Cannot find path 'C:\temp\temp' because it does not exist."There was a problem hiding this comment.
That's true, this makes sense
| else { | ||
| resolvedPath = SessionState.Path.GetResolvedPSPathFromPSPath(value).First().Path; | ||
| } | ||
| if (WildcardPattern.ContainsWildcardCharacters(value)) |
There was a problem hiding this comment.
The problem with wildcards in the path is that they can return multiple matches, and then which path do we use? Whatever we choose will not be apparent to the user, unless we write out a message.
I feel we should not support wildcards in this case, and require the user to provide a single path that resolves to a real location. If not then that is a terminating error. We don't need to test the path and return an error, because GetResolvedPSPathFromPSPath already does this and throws an exception with a readable error:
"Cannot find path 'C:\temp\temp' because it does not exist."
Make -Path a required parameter for Save-PSResource cmdlet
alyssa1303
added
PR-Bug
PR Summary
This PR makes
-Patha required parameter forSave-PSResourcecmdlet and changes its logic.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.