Update api calls for Find and Install #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anamnavi
commented
Sep 15, 2022
src/code/IFindPSResource.cs
Outdated
| /// </summary> | ||
| PSResourceInfo FindTypes(ResourceType packageResourceType, string packageName, PSRepositoryInfo repository, bool includePrerelease); | ||
|
|
||
| /// <summary> | ||
| /// Find method which allows for searching for command names and returns latest version of matching packages. | ||
| /// Name: supports wildcards | ||
| /// Name: no wildcard support |
There was a problem hiding this comment.
With this API call, we can support wildcards. So do we want to revert this change back?
Suggested change
| /// Name: no wildcard support | |
| /// Name: supports wildcards. |
anamnavi
added a commit
to anamnavi/PowerShellGet
that referenced
this pull request
Mar 16, 2023
* update IInstallPSResource and IFindPSResource with API calls * Update src/code/IFindPSResource.cs * Update src/code/IFindPSResource.cs
anamnavi
added a commit
to anamnavi/PowerShellGet
that referenced
this pull request
Mar 16, 2023
* update IInstallPSResource and IFindPSResource with API calls * Update src/code/IFindPSResource.cs * Update src/code/IFindPSResource.cs
anamnavi
added a commit
to anamnavi/PowerShellGet
that referenced
this pull request
Mar 16, 2023
* update IInstallPSResource and IFindPSResource with API calls * Update src/code/IFindPSResource.cs * Update src/code/IFindPSResource.cs
anamnavi
added a commit
to anamnavi/PowerShellGet
that referenced
this pull request
Mar 17, 2023
* update IInstallPSResource and IFindPSResource with API calls * Update src/code/IFindPSResource.cs * Update src/code/IFindPSResource.cs
anamnavi
added a commit
to anamnavi/PowerShellGet
that referenced
this pull request
Mar 17, 2023
* update IInstallPSResource and IFindPSResource with API calls * Update src/code/IFindPSResource.cs * Update src/code/IFindPSResource.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add and update API calls' notes for Find and Install scenarios.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.