PSUseDeclaredVarsMoreThanAssignment not correctly handling array adds and final assignment

[HowardWolosky]

This is a continuation of Issue #699 which I previously opened. It was closed as being resolved, but this issue remains.

Steps to reproduce

$resourceParams = @('a1', 'b1', c1')
$params = Get-Variable -Name $resourceParams -ErrorAction SilentlyContinue |
                  ForEach-Object { $m = @{} } { $m[$_.Name] = $_.Value } { $m } # foreach begin{} process{} end{}

Expected behavior

No reported issue

Actual behavior

PSUseDeclaredVarsMoreThanAssignments    Warning    The variable 'm' is assigned but never used.

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.18287.1001
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.18287.1001
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

> (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }
1.17.1
1.10.0
1.4.0

[JeremyTBradshaw]

+1, I notice this issue too. Another scenario that exposes it is this:

if ( 1+1 = 2) {$a = 'b'} else {$a = 'c'}
Write-Output $a

Since $a is declared twice but used once, a problem is reported.

[Panzerbjrn]

I just wanted to +1 this.
My code:
`
$Roles = Get-SCUserRoleMembership -UserName $Username
$Roles | ForEach-Object {IF ($_.UserRoleProfile -eq "Administrator") {$IsAdmin = $True}}

IF ($IsAdmin -ne $True)
{
"User is not admin"
}`

$ISAdmin is both declared and then used, but I still get "The variable 'IsAdmin' is assigned but never used."

[jonfortescue]

+1, I'm seeing this as well.

        $found = $false
        $repos | % {
            if ($_.Item1 -ieq $r) {
                $found = $true
            }
        }
        if (-Not $found) {
            throw "..."
        }

$found is said to be declared but never used within the ForEach-Object scope.

[rjmholt]

Duplicate of #1163