Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic errors in AvoidAlias rule #1251

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Fix logic errors in AvoidAlias rule #1251

merged 2 commits into from
Jun 5, 2019

Commits on Jun 5, 2019

  1. Fix logic errors in AvoidAlias rule 

    The first fix is that after the yield return, we should move on to the next command
The second fix is that if we find _any_ command, we should not move on to the 'Get-<command>' variant
These changes mean that we do not run a pipeline (twice!) to find something that was a cache miss. In the pathological case of a script mmade up of only unique aliases, we would run 2 pipelines for each found alias.
    @JamesWTruher
    JamesWTruher committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    8d91e1e View commit details
    Browse the repository at this point in the history

  2. Update Rules/AvoidAlias.cs 

    Co-Authored-By: Christoph Bergmeister [MVP] <c.bergmeister@gmail.com>
    @JamesWTruher @bergmeister
    JamesWTruher and bergmeister authored Jun 5, 2019
    Configuration menu
    Copy the full SHA
    1781717 View commit details
    Browse the repository at this point in the history