Skip to content

Remove obsolete GetCommandInfoLegacy method and use GetCommandInfo instead #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2020
Merged

Remove obsolete GetCommandInfoLegacy method and use GetCommandInfo instead #1387

merged 1 commit into from
Jan 3, 2020

Conversation

bergmeister
Copy link
Collaborator

PR Summary

In the past we could not remove them because it broke tests but now it seems that tests are OK.
There is a risk for a regression that is not covered by tests but especially with the new way of PSSA being hosted, it feels more worth of a try now.

PR Checklist

@bergmeister bergmeister changed the title Remove legacy methods Remove obsolete GetCommandInfoLegacy method and use GetCommandInfo instead Jan 3, 2020
@bergmeister bergmeister merged commit 1c0cfef into PowerShell:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Area - Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bergmeister @rjmholt