Handle cases where the Signature generator fails catastrophically #1661
+44
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils catastrophically
rjmholt
reviewed
Apr 12, 2021
...mpatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Collection/TypeDataCollector.cs
Outdated
Show resolved
Hide resolved
...mpatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Collection/TypeDataCollector.cs
Outdated
Show resolved
Hide resolved
...mpatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Collection/TypeDataCollector.cs
Outdated
Show resolved
Hide resolved
...mpatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Collection/TypeDataCollector.cs
Outdated
Show resolved
Hide resolved
...mpatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Collection/TypeDataCollector.cs
Outdated
Show resolved
Hide resolved
...mpatibilityCollector/Microsoft.PowerShell.CrossCompatibility/Collection/TypeDataCollector.cs
Outdated
Show resolved
Hide resolved
…ty/Collection/TypeDataCollector.cs Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
…ty/Collection/TypeDataCollector.cs Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>
rjmholt
approved these changes
Apr 12, 2021
rjmholt
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In the profile collector, there are some cases when we attempt to generate a method signature the framework will generate a platform not supported exception which causes the profile generation to fail.
We're not yet shipping the collector as a standalone module (as we think we may change it in the future), but we would like the functionality to work correctly.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.