Add exception message for missing rules #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmeister
requested review from
andyleejordan and
bergmeister
as code owners
bergmeister
reviewed
Feb 17, 2025
| CultureInfo.CurrentCulture, | ||
| Strings.RulesNotFound), | ||
| ErrorCategory.ResourceExists, | ||
| new Exception(errorMessage), |
There was a problem hiding this comment.
where this error is thrown, are we sure the only reason could be missing rules @Tadas ?
Kicked off CI for now to see what tests say
There was a problem hiding this comment.
@bergmeister I know we didn't get an answer to this; thoughts on merging for v1.3?
There was a problem hiding this comment.
actually, on closer inspection of the diff, only 2 things are changing and they aren't of concern:
- errorMessage is passed into Exception instead of nothing, which is an improvement
- ErrorCategory is changed from ResourceExists to ResourceUnavailable, which I guess is a bit better but
ObjectNotFoundis maybe even better so will change it to that. This is the same category thatgci notExistsreturns
bergmeister
reviewed
Mar 14, 2025
bergmeister
reviewed
Mar 14, 2025
bergmeister
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1875
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.