Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup new OneBranch pipeline #2027

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Setup new OneBranch pipeline #2027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28ee69a
Delete deprecated files
andyleejordan Sep 10, 2024
57ae6e0
Small updates
andyleejordan Sep 10, 2024
08c24ea
Remove `dotnet` bootstrap/installation code
andyleejordan Sep 10, 2024
9a00d23
Setup OneBranch and package build
andyleejordan Sep 11, 2024
5637f39
Fix unit tests for PowerShell 7.4
andyleejordan Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions .azure-pipelines-ci/ci.yaml
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions .azure-pipelines-ci/templates/test-powershell.yaml
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions .azure-pipelines-ci/templates/test-pwsh.yaml
View file
Open in desktop

This file was deleted.

214 changes: 0 additions & 214 deletions .ci/releaseBuild.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .config/tsaoptions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"projectName": "One",
"areaPath": "One\\MGMT\\Compute\\Powershell\\Powershell\\PowerShell Core",
"notificationAliases": [
"jimtru@microsoft.com",
"andschwa@microsoft.com",
"slee@microsoft.com"
],
"codebaseName": "PSSA_202403"
Expand Down
6 changes: 0 additions & 6 deletions .devcontainer/Dockerfile
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions .devcontainer/devcontainer.json
View file
Open in desktop

This file was deleted.

11 changes: 11 additions & 0 deletions .github/workflows/ci-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ jobs:
run: ./build.ps1 -Configuration Release -All
shell: pwsh

- name: Package
run: ./build.ps1 -BuildNupkg
shell: pwsh

- name: Test
run: ./build.ps1 -Test
shell: pwsh
Expand All @@ -45,6 +49,13 @@ jobs:
if: matrix.os == 'windows-latest'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add another 'OS' in the matrix so that there is one windows run for powershell core and one for windows powershell so that it can finisher quicker.
What we've lost with this test approach is that the test job used to be its own job just consuming the binary as artefacts (and the repo checkout because of test files although they should've technically also been an artefact). This ensured that the built binaries were sufficient and weren't relying on something else left lying around from the build

shell: powershell

- name: Upload build artifacts
uses: actions/upload-artifact@v4
if: always()
with:
name: PSScriptAnalyzer-package-${{ matrix.os }}
path: out/**/*.nupkg

- name: Upload test results
uses: actions/upload-artifact@v4
if: always()
Expand Down
Loading