Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SMA version #2028

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Bump SMA version #2028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Engine/Engine.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@


<ItemGroup Condition="'$(TargetFramework)' == 'net6'">
<PackageReference Include="System.Management.Automation" Version="7.0.11" />
<PackageReference Include="System.Management.Automation" Version="7.0.13" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyleejordan Why not 7.2.23? I believe 7.0.x was from days where we still had to support PowerShell 7.0. Now it's just 7.2 and after November 8, it will be just 7.4 (which will also mean we will be able to bump .NET version to 8) https://learn.microsoft.com/en-us/powershell/scripting/install/powershell-support-lifecycle?view=powershell-7.4#powershell-end-of-support-dates

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah fair but we should do that for a point release, not a patch release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So @bergmeister I actually have to circle back and do this now 😅

</ItemGroup>
<PropertyGroup Condition="'$(TargetFramework)' == 'net6'">
<DefineConstants>$(DefineConstants);PSV7;CORECLR</DefineConstants>
Expand Down