Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke-ScriptAnalyzer: Stream diagnostics instead of batching #2062

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

MatejKafka
Copy link
Contributor

PR Summary

Before this PR, diagnostics for all analyzed files in this pipeline step were batched and logged at once. Now, diagnostics are rendered immediately when the processing of a specific file is finished.

PR Checklist

Before this commit, diagnostics for all analyzed files in this pipeline step were batched and logged at once. With this commit, diagnostics are rendered immediately.
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah using a generator here instead of collecting everything into an accumlated list seems much better.

@andyleejordan andyleejordan enabled auto-merge (squash) February 25, 2025 00:08
@andyleejordan andyleejordan merged commit 56c6ea1 into PowerShell:main Feb 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants