Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test PowerShell Preview in CI #2070

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Test PowerShell Preview in CI #2070

merged 1 commit into from
Mar 13, 2025

Conversation

andyleejordan
Copy link
Member

Replaces #1439.

@andyleejordan
Copy link
Member Author

andyleejordan commented Mar 1, 2025 •
edited
Loading

Funny day year to test this, the daily isn't available.

@andyleejordan andyleejordan mentioned this pull request Mar 4, 2025
Closed
6 tasks
@andyleejordan
Copy link
Member Author

So apparently the Daily build hasn't existed in a year. I opened PowerShell/PowerShell#25124 to correct the install script, and I don't expect this to pass until it's merged as I updated it to install the preview to ~/.powershell-preview (like the Daily was) which makes way more sense.

@andyleejordan andyleejordan mentioned this pull request Mar 5, 2025
Open
21 tasks
@bergmeister
Copy link
Collaborator

Lol. But given that there are now multiple supported PowerShell versions available (LTS and current), the more valuable thing is maybe to test with those versions and the latest preview. Also, daily probably adds a bit of noise.

@andyleejordan andyleejordan changed the title Test PowerShell daily in CI Test PowerShell Preview in CI Mar 13, 2025
@andyleejordan
Copy link
Member Author

Ah I didn't update the title. This will test the PowerShell Preview, I'm just waiting on my upstream PR to be merged so I don't have to install it to a -Destination manually.

@andyleejordan andyleejordan enabled auto-merge (squash) March 13, 2025 17:04
@andyleejordan andyleejordan disabled auto-merge March 13, 2025 17:07
@andyleejordan andyleejordan force-pushed the daily branch 2 times, most recently from 3ca30c0 to 52f3d41 Compare March 13, 2025 17:36
@andyleejordan andyleejordan enabled auto-merge (squash) March 13, 2025 17:45
@andyleejordan andyleejordan disabled auto-merge March 13, 2025 17:47
@andyleejordan
Test PowerShell Preview in CI
b44f92f 
Since the Daily no longer exists.
SeeminglyScience
SeeminglyScience approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit bbf258b into main Mar 13, 2025
6 checks passed
@andyleejordan andyleejordan deleted the daily branch March 13, 2025 18:39
@bergmeister
Copy link
Collaborator

Ah I didn't update the title. This will test the PowerShell Preview, I'm just waiting on my upstream PR to be merged so I don't have to install it to a -Destination manually.

Gotcha. Makes sense. But I think it would also be useful to additionally also have one run with PowerShell 7.4 since it is LTS but the CI runners always use the latest version, which is 7.5 atm. For now we could just run test suite with PS 7.4 locally, just requires manual uninstall of newer versions because some tests call into pwsh from PATH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

@bergmeister bergmeister Awaiting requested review from bergmeister bergmeister is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyleejordan @bergmeister @SeeminglyScience