PSReviewUnusedParameter false positive for ValueFromPipeline #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
approved these changes
Mar 5, 2025
auto-merge was automatically disabled
March 10, 2025 19:30
Head branch was pushed to by a user without write access
bergmeister
approved these changes
Mar 13, 2025
…t directly contains variable usage of $_ or $PSItem. Then when we encounted a parameter with ValueFromPipeline set, we consider whether we saw usage within a process block by automatic variable.
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
andyleejordan
force-pushed
the
#1840PSReviewUnusedParameterVsValueFromPipeline
branch
from
95e1486 to
d83b1d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Whether good practice or not, a parameter defined with
ValueFromPipelineis flagged as unused when referred to by$_or$PSItemwithin the process block of a function.This PR checks for
ValueFromPipelinewhen the parameter's usage is inspected. If set,$_and$PSItemcount towards it's usage when seen in a process block.Fixes #1840
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.