Skip to content

Conversation

@kapilmb
Copy link

@kapilmb kapilmb commented Feb 12, 2016

Review on Reviewable

@joeyaiello
Copy link
Contributor

Resolves #434

@raghushantha
Copy link
Member

:lgtm:


Comments from the review on Reviewable.io

@raghushantha
Copy link
Member

Reviewed 16 of 16 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@raghushantha
Copy link
Member

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Rules/UseToExportFieldsInManifest.cs, line 102 [r2] (raw file):
Can you add a comment here as to how the *ToExport fields are processed? Ex: What if it contains a collection that might have wildcards..?


Comments from the review on Reviewable.io

@kapilmb
Copy link
Author

kapilmb commented Feb 16, 2016

Review status: 16 of 17 files reviewed at latest revision, 1 unresolved discussion.


Rules/UseToExportFieldsInManifest.cs, line 102 [r2] (raw file):
Done.


Comments from the review on Reviewable.io

@raghushantha
Copy link
Member

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

kapilmb pushed a commit that referenced this pull request Feb 16, 2016
New rule to check if the ToExport fields in manifest are set to explicit lists.
@kapilmb kapilmb merged commit 38b9e99 into development Feb 16, 2016
@kapilmb kapilmb deleted the NewRuleUseToExportInManifest branch February 16, 2016 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants