Skip to content

Update the Trusted_Platform_Assemblies list #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

daxian-dbw
Copy link
Member

PR Summary

Update the Trusted_Platform_Assemblies list to be in sync with the TPA list of pwsh.exe from the min-size build (no WPF related dependencies).

PR Context

The TPA list were not updated for 7.3.0, which caused regression reported: PowerShell/PowerShell#18587

@@ -668,12 +668,14 @@ namespace NativeMsh
// NOTE: The names must not include the .dll extension because it will be added programmatically.
static PCSTR trustedAssemblies[] =
{
"getfilesiginforedistwrapper",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Member Author

@daxian-dbw daxian-dbw Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new list is generated from the trace output of pwsh.exe (the min-size package, so WPF things are not included) by setting the environment variable COREHOST_TRACE beforehand.
For this specific one, I don't know where it's pulled from.

@iSazonov
Copy link
Contributor

Maybe add new test in PowerShell repository? We will move to .Net 8 soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants