Skip to content

Hide the console for WinRM remoting #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Hide the console for WinRM remoting #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/powershell-native/nativemsh/pwrshplugin/pwrshclrhost.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ unsigned int PowerShellCoreClrWorker::LaunchClr(
{
// Allocate a console so that the codepage is setup correctly
AllocConsole();
HWND console = GetConsoleWindow();
if (console != NULL)
Copy link
Contributor

@iSazonov iSazonov Dec 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AllocateConsole returns HWND and since winrm haven't a console before the call returns real handle. It seems we have no need to call GetConsoleWindows.
https://learn.microsoft.com/en-us/windows/console/allocconsole

{
// Hide the console window
ShowWindow(console, SW_HIDE);
}

return commonLib->LaunchCoreCLR(hostWrapper, hostEnvironment, friendlyName);
}

Expand Down