Skip to content

ExperimentalFeature, PSEdition, Noun and JoinItem Argument completers don't handle single/double quotes for parameter text completion #24873

Closed
@ArmaanMcleod

Description

@ArmaanMcleod

Prerequisites

Steps to reproduce

Follow up from #24838.

The below argument completers do not handle single/double quote parameter text completion:

  • ExperimentalFeatureNameCompleter
  • PSEditionArgumentCompleter
  • NounArgumentCompleter
  • JoinItemCompleter

Which will probably be simpler to address once #24839 is merged since this refactoring ensures the internal method CompletionCompleters.GetMatchingResults which calls the HandleDoubleAndSingleQuote for the single/double quote completion code across these completers as well.

Expected behavior

PS> Get-ExperimentalFeature -Name PS -> Completes to PSFeedbackProvider
PS> Get-ExperimentalFeature -Name 'PS -> Completes to 'PSFeedbackProvider'
PS> Get-ExperimentalFeature -Name "PS -> Completes to "PSFeedbackProvider"

PS> Get-Module -PSEdition C -> Completes to Core
PS> Get-Module -PSEdition 'C -> Completes to 'Core'
PS> Get-Module -PSEdition "C -> Completes to "Core"

PS> Get-Command -Noun A -> Completes to Acl
PS> Get-Command -Noun 'A -> Completes to 'Acl'
PS> Get-Command -Noun "A Completes to "Acl"

PS> Join-String -Separator  -> Completes to ', '
PS> Join-String --Separator ' -> Completes to ', '
PS> Join-String -Separator " -> Completes to ", "

Actual behavior

PS> Get-ExperimentalFeature -Name PS -> Completes to PSFeedbackProvider
PS> Get-ExperimentalFeature -Name 'PS -> Does not complete to 'PSFeedbackProvider'
PS> Get-ExperimentalFeature -Name "PS -> Does not complete to "PSFeedbackProvider"

PS> Get-Module -PSEdition C -> Completes to Core
PS> Get-Module -PSEdition 'C -> Does not complete to 'Core'
PS> Get-Module -PSEdition "C -> Does not complete to "Core"

PS> Get-Command -Noun A -> Completes to Acl
PS> Get-Command -Noun 'A -> Does not complete to 'Acl'
PS> Get-Command -Noun "A -> Does not complete to "Acl"

PS> Join-String -Separator  -> Completes to ', '
PS> Join-String --Separator ' -> Does not complete to ', '
PS> Join-String -Separator " -> Does not complete to ", "

Error details

Environment data

Name                           Value
----                           -----
PSVersion                      7.5.0-preview.3
PSEdition                      Core
GitCommitId                    7.5.0-preview.3-241-g2e97dd4d5ae2b1a3c5440fe8f91777059db27b89
OS                             Microsoft Windows 10.0.26100
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visuals

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions