Skip to content

Additional Microsoft Modules to track in PS7 Telemetry #10751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 11, 2019

Conversation

SydneyhSmith
Copy link
Contributor

@SydneyhSmith SydneyhSmith commented Oct 9, 2019

PR Summary

This adds additional Microsoft-owned modules to be tracked at load time in the PowerShell 7 telemetry.

PR Context

This allows us to better understand how PowerShell is being used to manage services and to better understand the types of PowerShell users based on which modules are loaded into PowerShell sessions.

PR Checklist

Adding additional Microsoft-owned modules to be tracked at load time in the PowerShell 7 telemetry.
@iSazonov iSazonov requested a review from JamesWTruher October 10, 2019 15:29
@SteveL-MSFT SteveL-MSFT changed the title Additional Microsoft Modules to track in PS7 Telemetry WIP: Additional Microsoft Modules to track in PS7 Telemetry Oct 10, 2019
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 10, 2019
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 10, 2019
Updating to include non-gallery modules queried from Microsoft Docs.
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeyaiello needs to review this list for accuracy

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 11, 2019
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.1 milestone Nov 23, 2019
@ghost ghost assigned TravisEz13 Nov 23, 2019
@TravisEz13
Copy link
Member

@SteveL-MSFT does this need to get in the RC?

@SteveL-MSFT
Copy link
Member

@TravisEz13 yes

Copy link
Contributor

@joeyaiello joeyaiello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew. Finally got through this one.

We have lots of work to do in renaming Windows PowerShell modules in the Microsoft Docs, @sdwheeler, I took some notes along the way.

"AzureRm.UsageAggregates",
"AzureRm.Websites",
"AzureRmStorageTable",
"AzureStorageTools",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not us, please remove

Co-Authored-By: Joey Aiello <joeyaiello@users.noreply.github.com>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 4, 2019
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok from me once @joeyaiello approves

@SydneyhSmith SydneyhSmith changed the title WIP: Additional Microsoft Modules to track in PS7 Telemetry Additional Microsoft Modules to track in PS7 Telemetry Dec 5, 2019
@adityapatwardhan
Copy link
Member

@SteveL-MSFT @joeyaiello Please re-review.

Copy link
Contributor

@joeyaiello joeyaiello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Approving operating under the assumption that this list is not case sensitive (assuming that's what StringComparer.OrdinalIgnoreCase does, but I never can remember the exact behavior around ordinal vs. non-ordinal).

If it is case-sensitive, I have to make some more changes ASAP

@adityapatwardhan adityapatwardhan merged commit 4fb5f94 into PowerShell:master Dec 11, 2019
@adityapatwardhan adityapatwardhan added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Dec 11, 2019
@ghost
Copy link

ghost commented Dec 16, 2019

🎉v7.0.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Engine Indicates that a PR should be marked as an engine change in the Change Log MustHave
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants