-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Additional Microsoft Modules to track in PS7 Telemetry #10751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding additional Microsoft-owned modules to be tracked at load time in the PowerShell 7 telemetry.
Updating to include non-gallery modules queried from Microsoft Docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joeyaiello needs to review this list for accuracy
@SteveL-MSFT does this need to get in the RC? |
@TravisEz13 yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew. Finally got through this one.
We have lots of work to do in renaming Windows PowerShell modules in the Microsoft Docs, @sdwheeler, I took some notes along the way.
"AzureRm.UsageAggregates", | ||
"AzureRm.Websites", | ||
"AzureRmStorageTable", | ||
"AzureStorageTools", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not us, please remove
Co-Authored-By: Joey Aiello <joeyaiello@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok from me once @joeyaiello approves
@SteveL-MSFT @joeyaiello Please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Approving operating under the assumption that this list is not case sensitive (assuming that's what StringComparer.OrdinalIgnoreCase
does, but I never can remember the exact behavior around ordinal vs. non-ordinal).
If it is case-sensitive, I have to make some more changes ASAP
🎉 Handy links: |
PR Summary
This adds additional Microsoft-owned modules to be tracked at load time in the PowerShell 7 telemetry.
PR Context
This allows us to better understand how PowerShell is being used to manage services and to better understand the types of PowerShell users based on which modules are loaded into PowerShell sessions.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.