Revert "Update formatter to not write newlines if content is empty (#11193)"

[iSazonov]

PR Summary

This reverts commit 51d2523. (#11193)

PR Context

Fix #11340

It seems we filter out a null too late.
We need to have more info about a scenario we tried to fix in #11193.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[SteveL-MSFT]

Should we add a test for the Get-Help scenario?

[iSazonov]

Should we add a test for the Get-Help scenario?

The scenario is a side effect. If we change Get-Help we can lost the new test. I don't know how create more common and reliable test.

[SteveL-MSFT]

@iSazonov not suggesting we change Get-Help itself, but a test for (Get-Help Out-Null).Examples

[iSazonov]

I will pull the test in follow PR (revert PR is not right place).

[daxian-dbw]

@iSazonov @SteveL-MSFT Since #11193 was reverted, is there an issue opened to track the original problem that PR was trying to fix?

[iSazonov]

@daxian-dbw Original issue was discovered by @SteveL-MSFT but not registered so we haven't tracking issue. I do not know whether it is important for @SteveL-MSFT.

[ghost]

🎉v7.1.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes