[Regression] Fix for JEA user role in virtual account

[PaulHigin]

PR Summary

This is issue #11538.

JEA user role access was not being set correctly for a user in a JEA session endpoint configuration that is configured for RunAs or virtual accounts.

PR Context

The user role access was not being allowed for RunAs/virtual accounts because the endpoint configuration was setting the UseSharedProcess to True. In this case the WinRM host cannot provide a user token needed by PowerShell to assign role access.

This is a regression from PS6, due to workflow clean up effort (#9618). The Register-PSSessionConfiguration command would automatically set an endpoint configuration to UseSharedProcess to True for workflow endpoints. Code clean up typo left the code to always set UseSharedProcess to True for any endpoint configuration by default.

Simple fix is to remove the old workflow code completely so that UseShareProcess is False by default, and only enabled by user as it works in Windows PowerShell and PowerShell 6+.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[iSazonov]

I added reference to #9618 where we did workflow cleanup.

[iSazonov]

Have we any progress with adding remoting tests?
I hope MSFT team has such tests internally at least.

[daxian-dbw]

This is a regression from PS6, due to workflow clean up effort (#9618).

Great finding. It's hard to track down the regression caused by subtle changes like this one.
@iSazonov there is on-going efforts to setup the cross-remoting test infrastructure, but even after the infrastructure is ready, there will still be some time before we have the desired coverage in remoting scenarios.

[ghost]

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes