Generate guid for FormatViewDefinition InstanceId if not provided #11896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
InstanceId
for aFormatViewDefinition
is the key to help differentiate views with the same name for the same type. However, when using the constructor forFormatViewDefinition
that doesn't take an InstanceId, it keeps the default guid value of all zeros. During export time, the cmdlet builds a dictionary with the InstanceId as the key and with multiple views with same key, you only get the first one. Fix is to generate a new guid for InstanceId if one is not provided.PR Context
Fix #11825
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.