-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add telemetry to check for specific tags when importing a module #20371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry to check for specific tags when importing a module #20371
Conversation
8106dd6
to
6ac4c01
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This allows us to more easily add tags in the future if we need it.
35bf161
to
19fe57e
Compare
📣 Hey @JamesWTruher, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://forms.office.com/r/P926k48jRJ |
PR Summary
We would like to be able to determine whether Crescendo is being used by tracking module import and see whether the the
CrescendoBuilt
tag has been applied to the module. This PR generalizes the tag inspection so we can add additional tags in the future.we also need to add this to the document which describes what telemetry we collect.
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).