Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code of Conduct and Security Policy #23811

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented May 16, 2024

PR Summary

Updates the readme, code of conduct and security policy.

PR Context

It was requested by OSPO.

PR Checklist

@andyleejordan andyleejordan force-pushed the andyleejordan/update-coc branch from 009a963 to 4d386c2 Compare May 16, 2024 21:49
@andyleejordan
Copy link
Member Author

I might suggest that we just remove the COC section from the bottom of the readme, as GitHub now shows readme/COC/license as tabs on the repo's main page.

@andyleejordan andyleejordan marked this pull request as draft May 16, 2024 22:05
@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 20, 2024
@andyleejordan andyleejordan force-pushed the andyleejordan/update-coc branch from 4d386c2 to 90a46e9 Compare June 12, 2024 22:00
@microsoft-github-policy-service microsoft-github-policy-service bot removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Jun 12, 2024
@andyleejordan andyleejordan changed the title Update CODE_OF_CONDUCT.md Update Code of Conduct and Security Policy Jun 12, 2024
@andyleejordan andyleejordan marked this pull request as ready for review June 12, 2024 22:01
@andyleejordan
Copy link
Member Author

This has been updated and ready for review. We unfortunately cannot rely on the organization templates.

@andyleejordan andyleejordan force-pushed the andyleejordan/update-coc branch from 90a46e9 to 61c79c2 Compare June 12, 2024 22:52
@andyleejordan andyleejordan requested review from SteveL-MSFT and removed request for TravisEz13 June 12, 2024 22:53
@andyleejordan andyleejordan force-pushed the andyleejordan/update-coc branch from 61c79c2 to 46e2bdf Compare June 12, 2024 23:01
@andyleejordan
Copy link
Member Author

I fixed the spell-checked "spellchecked" typo that was failing the Markdown linter since I caused it to trigger by editing the contributing document. As we need to use the security policy file verbatim(ish) I added an exclusion to the linter for it.

@andyleejordan
Copy link
Member Author

Also, I'm unsure why so many links in the readme and other existing documentation could be relative but instead are hard links to the master branch's tree on GitHub...but there are some relative links used so I went with that.

Finally, I specifically didn't move the files from where they already were even though they could both be in .github or the root, but with too many other links out there pointing to them it would be a frustrating move for no reason.

@andyleejordan andyleejordan enabled auto-merge (squash) June 13, 2024 06:42
@andyleejordan andyleejordan disabled auto-merge June 13, 2024 17:15
@andyleejordan andyleejordan force-pushed the andyleejordan/update-coc branch from 46e2bdf to 9767d7a Compare June 14, 2024 22:52
@andyleejordan
Copy link
Member Author

andyleejordan commented Jun 14, 2024

I added:

DO enforce the Code of Conduct by taking reports of abuse and violations to the committee for resolution

as a requirement for both repository maintainers and PowerShell Committee members. Then I spelled out (copied the existing, and linked to it in contributing guidelines) the enforcement policy followed by the committee.

Finally I added a note to the PowerShell Committee that employees should review the resources available at https://aka.ms/opensource/moderation-support.

While I've added these two requirements, I don't believe they need to be explicitly approved as they were implicit requirements, and now they're spelled out explicitly.

Updates the readme, code of conduct and security policy per OSPO request.
@andyleejordan andyleejordan force-pushed the andyleejordan/update-coc branch from 9767d7a to 6b0c20e Compare June 14, 2024 23:02
@andyleejordan
Copy link
Member Author

(And fixed more Markdown linter issues I triggered by touching the files.)

@andyleejordan andyleejordan enabled auto-merge (squash) June 14, 2024 23:14
@andyleejordan andyleejordan merged commit 7ec8e4e into master Jun 14, 2024
40 checks passed
Copy link
Contributor

microsoft-github-policy-service bot commented Jun 14, 2024

📣 Hey @andyleejordan, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@TravisEz13 TravisEz13 deleted the andyleejordan/update-coc branch July 9, 2024 18:53
@SeeminglyScience SeeminglyScience added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Aug 20, 2024
chrisdent-de pushed a commit to chrisdent-de/PowerShell that referenced this pull request Sep 12, 2024
Updates the readme, code of conduct and security policy per OSPO request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants