-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use workload identity service connection to download makeappx tool from storage account #24817
Merged
adityapatwardhan
merged 1 commit into
PowerShell:master
from
adityapatwardhan:FixMakeAppxDownload
Jan 17, 2025
Merged
Use workload identity service connection to download makeappx tool from storage account #24817
adityapatwardhan
merged 1 commit into
PowerShell:master
from
adityapatwardhan:FixMakeAppxDownload
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom storage account
TravisEz13
approved these changes
Jan 17, 2025
/azp run PowerShell-CI-macos, PowerShell-CI-Linux, PowerShell-CI-Windows, PowerShell-CI-static-analysis, PSResourceGet ACR, PowerShell-Windows-Packaging-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
📣 Hey @adityapatwardhan, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
TravisEz13
pushed a commit
that referenced
this pull request
Jan 17, 2025
…rom storage account (#24817)
21 tasks
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Feb 24, 2025
…rom storage account (PowerShell#24817)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BackPort-7.4.x-Done
BackPort-7.5.x-Approved
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We should be using workload identity service connection for accessing storage accounts.
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).